projects
/
gtk4.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
2250cd8
)
Remove a pointless comparison
author
Matthias Clasen
<mclasen@redhat.com>
Sun, 22 Mar 2015 19:16:14 +0000
(15:16 -0400)
committer
Matthias Clasen
<mclasen@redhat.com>
Sun, 22 Mar 2015 19:16:14 +0000
(15:16 -0400)
Comparing an unsigned value against < 0 is not going to succeed.
Pointed out by clang.
gtk/gtkprintoperation.c
patch
|
blob
|
history
diff --git
a/gtk/gtkprintoperation.c
b/gtk/gtkprintoperation.c
index 1f45c4fec557915c8654a43c94e30e1249fabb63..057430b4127ee2a99ad4f4c6229878760e27a557 100644
(file)
--- a/
gtk/gtkprintoperation.c
+++ b/
gtk/gtkprintoperation.c
@@
-1785,7
+1785,7
@@
_gtk_print_operation_set_status (GtkPrintOperation *op,
NC_("print operation status", "Finished with error")
};
- if (status
< 0 || status
> GTK_PRINT_STATUS_FINISHED_ABORTED)
+ if (status > GTK_PRINT_STATUS_FINISHED_ABORTED)
status = GTK_PRINT_STATUS_FINISHED_ABORTED;
if (string == NULL)